Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo: $domain not defined in scripts/change_url #441

Merged
merged 1 commit into from Sep 25, 2021
Merged

typo: $domain not defined in scripts/change_url #441

merged 1 commit into from Sep 25, 2021

Conversation

ketsapiwiq
Copy link
Contributor

Problem

root@yunohost:~# yunohost app change-url nextcloud -d nextcloud.example.com -p nextcloud
Info: [++..................] > Loading installation settings...
Info: [##+++...............] > Backing up the app before changing its URL (may take a while)...
Info: [#####+++++..........] > Updating NGINX web server configuration...
Info: [##########+++++.....] > Applying Nextcloud specific modifications...
Warning: ./change_url: line 120: domain: unbound variable
Warning: [Error] Upgrade failed.

Solution

  • Changed by $new_domain (I guess it's not $old_domain)

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@kay0u
Copy link
Member

kay0u commented Sep 17, 2021

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

tituspijean
tituspijean approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@tituspijean tituspijean left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's surprising the CI did not catch that. Would it be because it populates the domain variable for all scripts?

@kay0u
Copy link
Member

kay0u commented Sep 25, 2021

No, it's because package_check didn't test this case, I fixed it with: YunoHost/package_check@a53496e

@kay0u kay0u merged commit 8a95af4 into YunoHost-Apps:testing Sep 25, 2021
@ericgaspar ericgaspar mentioned this pull request Oct 9, 2021
Closed
@alexAubin alexAubin mentioned this pull request Oct 21, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tituspijean tituspijean tituspijean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ketsapiwiq @kay0u @yunohost-bot @tituspijean